Issue Details (XML | Word | Printable)

Key: GALAXY-259
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Mark Griffin
Reporter: Mark Griffin
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Galaxy

UI input data validation

Created: 13/May/08 11:34 AM   Updated: 23/May/08 08:30 AM
Component/s: Web
Affects Version/s: 1.0-RC
Fix Version/s: 1.0-RC

Time Tracking:
Not Specified

Issue Links:
Related

Labels:
User impact: Medium


 Description  « Hide
We need to define what fields are required and enforce this. Also, each screen should either give a success or failure response to the user action.

 All   Comments   Work Log   Change History   Transitions   FishEye      Sort Order: Ascending order - Click to sort in descending order
Andrew Perepelytsya added a comment - 13/May/08 11:42 AM
Mark, only 1 admin screen was missing the confirmation message (see the linked issue).

Dan Diephouse added a comment - 13/May/08 12:50 PM
It'd be great if we could just add this into AbstractForm so all forms get validation. We could setup forms like so:

addField("Description", descriptionWidget, validator)

or something like that.


Andrew Perepelytsya added a comment - 13/May/08 12:57 PM
I doubt that would work for non-simple cases, when relations between fields have to be taken into account. For this matter, an additional generic validate() method would probably be needed.

Mark Griffin added a comment - 13/May/08 02:41 PM
I like the idea of adding abstract void validate(); to AbstractForm and having each subclass override it. I can't imagine a form not needing some kind of validation.