Issue Details (XML | Word | Printable)

Key: MULE-3632
Type: Task Task
Status: Open Open
Priority: Critical Critical
Assignee: Unassigned
Reporter: Johnny Tu
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Mule

Look into onEvent() method in VMMessageReceiver and investigate whether synchronized block is needed

Created: 24/Aug/08 09:44 PM   Updated: 16/Dec/08 06:05 PM
Component/s: Transport: VM
Affects Version/s: 1.4.4, 2.0.2
Fix Version/s: Tech. Debt

Time Tracking:
Not Specified

Labels: 22-candidates 22-commit 22-techdebt-candidates
User impact: Medium
Effort points: 2


 Description  « Hide
The synchronized block in this method seems to affect the performance of the VM transport as it restricts throughput. Given that there is already a comment in the code about whether the synchronized block is needed I think this it's worth investigating this a bit further.

public void onEvent(UMOEvent event) throws UMOException
{
/*

  • TODO HH: review: onEvent can only be called by the VMMessageDispatcher - why is
  • this lock here and do we still need it? what can break if this receiver is run
  • concurrently by multiple dispatchers?
    */
    UMOMessage msg = new MuleMessage(event.getTransformedMessage(), event.getMessage());
    synchronized (lock) { routeMessage(msg); }

}



 All   Comments   Work Log   Change History   Transitions   FishEye      Sort Order: Ascending order - Click to sort in descending order
There are no comments yet on this issue.