[#MULE-3783] Splash screen is missing the buildNumber

Mule

Splash screen is missing the buildNumber

Created: 06/Oct/08 11:22 AM Updated: 09/Oct/08 03:00 PM

Component/s:

Build: (other)

Affects Version/s:

2.1-M2

Fix Version/s:

2.0 ITR8, 2.1.1

Time Tracking:

Original Estimate:

Not Specified

Remaining Estimate:

0 minutes

Time Spent:

3 hours, 30 minutes

Environment:

Linux, JDK 5

Issue Links:

Related

This issue relates to:

~~MULE-3701~~ The 2.1.x build strips MANIFEST.MF of all entries

Labels:
User impact:	Medium
Configuration:	mule-2.1.x branch @ revision 12918
Log Output:	« Hide ********************************************************************** * Mule ESB and Integration Platform * * Version: 2.1.0 Build: ${buildNumber} * * MuleSource, Inc. * * For more information go to http://mule.mulesource.org * * * * Server started: 10/6/08 10:42 AM * * Server ID: 9aabc7ff-93ac-11dd-9ebd-a1238f511693 * * JDK: 1.5.0_13 (mixed mode) * * Encoding: OS: UTF-8, Mule: UTF-8 * * OS: Linux (2.6.22-15-generic, i386) * * Host: elijah (192.168.1.7) * * * * Agents Running: None * ******************************************************************** Show » ******************************************************************** * Mule ESB and Integration Platform * * Version: 2.1.0 Build: ${buildNumber} * * MuleSource, Inc. * * For more information go to http://mule.mulesource.org * * * * Server started: 10/6/08 10:42 AM * * Server ID: 9aabc7ff-93ac-11dd-9ebd-a1238f511693 * * JDK: 1.5.0_13 (mixed mode) * * Encoding: OS: UTF-8, Mule: UTF-8 * * OS: Linux (2.6.22-15-generic, i386) * * Host: elijah (192.168.1.7) * * * * Agents Running: None * **********************************************************************

Description

« Hide

The splash screen is displaying:

Version: 2.1.0 Build: ${buildNumber} *

The ${buildNumber} should be getting replaced by the real build version/number.

All

Comments

Work Log

Change History

Transitions

FishEye

Sort Order:

[ Permlink | « Hide ]

Dirk Olmes added a comment - 07/Oct/08 09:38 AM

I'd say this is an issue with the bundle plugin as the properties seem to get passed into the bundle plugin just fine (note the Build-Revison:

[DEBUG] Configuring mojo 'org.apache.felix:maven-bundle-plugin:1.4.3:bundle' -->
[...]
[DEBUG] (f) instructions = {Build-Date=2008-Oct-07 16:34:27, Build-Revision=12935, Build-bar=org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType, Bundle-DocURL=http://mule.mulesource.org/mule-core, Bundle-SymbolicName=mule-core, _include=-osgi.properties}

But the resulting jar's MANIFEST.MF does not have the properties substituted.

[ Permlink | « Hide ]

Dirk Olmes added a comment - 07/Oct/08 09:58 AM

One more hint: If I define a manifest entry with a different name, e.g. Mule-Revision, that will be properly substituted into the final MANIFEST.MF.

[ Permlink | « Hide ]

Travis Carlson added a comment - 07/Oct/08 10:23 AM

Yep, that's the cause. Build-Date has the same problem:

Bundle-DocURL: http://mule.mulesource.org/mule-core
Build-Date: ${timestamp}
Bundle-Vendor: MuleSource, Inc.
Bundle-SymbolicName: mule-core

[ Permlink | « Hide ]

Dirk Olmes added a comment - 07/Oct/08 11:39 AM

On more investigation it turns out that the property substitution does not occur if the same properties are declared for the bundle plugin and for the jar plugin. If the Build-Revision property is configured on the bundle plugin only, it properly gets substituted.

[ Permlink | « Hide ]

Dirk Olmes added a comment - 08/Oct/08 03:52 AM

We decided to convert the last Maven modules, that still produce regular jars to bundles as well so we can get rid of the configuration of the jar plugin altogether.

[ Permlink | « Hide ]

Dirk Olmes added a comment - 08/Oct/08 03:54 AM

Travis, you volunteered to convert the remaining jars to bundles, assigning to you.

[ Permlink | « Hide ]

Daniel Feist added a comment - 09/Oct/08 01:20 PM

Not sure we want to convert test jar's just for to fix this issue.. anyway for now we decided to remove this property from jar plugin config so we can build number info in splashscreen and via JMX.

[ Permlink | « Hide ]

Daniel Feist added a comment - 09/Oct/08 03:00 PM

http://svn.mule.codehaus.org/changelog/mule/?cs=13005